Changeset 2850

Timestamp:

05/25/10 11:21:48 (14 years ago)

Author:

niltonneto

Message:

Ticket #1041 - Corrigido problema na validação da sessão por IP.

Location:

branches/2.0

Files:

• header.session.inc.php (modified) (2 diffs)
• logout.php (modified) (1 diff)
• phpgwapi/inc/class.sessions.inc.php (modified) (1 diff)

branches/2.0/header.session.inc.php

@@ -1 +1 @@
 <?php
-        if ( isset( $_COOKIE[ 'sessionid' ] ) )
+    if ( isset( $_COOKIE[ 'sessionid' ] ) )
                 session_id( $_COOKIE[ 'sessionid' ] );
 
@@ -6 +6 @@
 
         $sess = $_SESSION[ 'phpgw_session' ];
-        $user_ip =  (isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? $_SERVER['HTTP_X_FORWARDED_FOR'] : $_SERVER['REMOTE_ADDR']);  
-        $connection_id = "{$sess['session_id']}{$user_ip}".substr($_SERVER[ 'HTTP_USER_AGENT' ],0,199);
-
-
-        if (empty($_SESSION['phpgw_session']['session_id']) || ($_SESSION['connection_db_info']['user_auth'] && implode('',$_SESSION['connection_db_info']['user_auth']) !== $connection_id))
+        $invalidSession = false;
+        $user_agent = array();
+        if (isset($GLOBALS['phpgw']) && !isset($_SESSION['connection_db_info'])){
+                if($GLOBALS['phpgw_info']['server']['use_https'] == 1) {
+                $new_ip = (isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? $_SERVER['HTTP_X_FORWARDED_FOR']."," : ""). $_SERVER['REMOTE_ADDR'];
+                $GLOBALS['phpgw']->db->query("UPDATE phpgw_access_log SET ip='$new_ip' WHERE account_id <> 0 and lo = 0 and sessionid='{$GLOBALS['sessionid']}'",__LINE__,__FILE__);
+                }
+                $GLOBALS['phpgw']->db->query("select trim(sessionid), ip, browser from phpgw_access_log where account_id <> 0 and lo = 0 and sessionid='{$GLOBALS['sessionid']}' limit 1",__LINE__,__FILE__);
+                $GLOBALS['phpgw']->db->next_record();
+                if($GLOBALS['phpgw']->db->row( ))
+                        $_SESSION['connection_db_info']['user_auth'] = implode("",$GLOBALS['phpgw']->db->row( ));
+        }
+        if($_SESSION['connection_db_info']['user_auth']){
+                $invalidSession = true;
+                $http_user_agent = substr($_SERVER[ 'HTTP_USER_AGENT' ],0,199);
+                $user_ip = isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? array($_SERVER['REMOTE_ADDR'], $_SERVER['HTTP_X_FORWARDED_FOR']) : array($_SERVER['REMOTE_ADDR']);
+                $user_agent[] = "{$sess['session_id']}{$user_ip[0]}".$http_user_agent;
+                if(count($user_ip) == 2) {
+                        $user_agent[] = "{$sess['session_id']}{$user_ip[1]}".$http_user_agent;
+                        $user_agent[] = $sess['session_id'].implode(",",array_reverse($user_ip)).$http_user_agent;
+                }
+                $pconnection_id = $_SESSION['connection_db_info']['user_auth'];
+                if(array_search($pconnection_id, $user_agent)  !== FALSE) {
+                        $invalidSession = false;
+                }
+        }
+        if (empty($_SESSION['phpgw_session']['session_id']) || $invalidSession)
         {
                 if($_SESSION['connection_db_info']['user_auth'] && !strstr($_SERVER['SCRIPT_URL'],"/controller.php")) {
-                        error_log( '[ INVALID SESSION ] >>>>' . implode('',$_SESSION['connection_db_info']['user_auth']) . '<<<< - >>>>' . $connection_id . '<<<<', 0 );
-                        @require_once dirname( __FILE__ ) . '/logout.php';
+                        error_log( '[ INVALID SESSION ] >>>>' .$_SESSION['connection_db_info']['user_auth'].'<<<< - >>>>' . implode("",$user_agent), 0 );
+                        require_once dirname( __FILE__ ) . '/logout.php';
                 }
 

branches/2.0/logout.php

@@ -20 +20 @@
                 'nonavbar'               => True
         );
-        include('./header.inc.php');
+        include(dirname( __FILE__ ).'/header.inc.php');
 
         $GLOBALS['sessionid'] = get_var('sessionid',array('GET','COOKIE'));

branches/2.0/phpgwapi/inc/class.sessions.inc.php

@@ -404 +404 @@
                 * Get the ip address of current users
                 *
-                * @return string ip address
+                * @return string HTTP_X_FORWARDED_FOR (if exists) and REMOTE_ADDR ip addresses.
                 */
                 function getuser_ip()
                 {
-                /*
-                        if (getenv(HTTP_X_FORWARDED_FOR))
-                        {
-                                if (getenv(HTTP_CLIENT_IP))
-                                {
-                                        $ip=getenv(HTTP_CLIENT_IP);
-                                }
-                                else
-                                {
-                                        $ip=getenv(HTTP_X_FORWARDED_FOR);
-                                }
-                                $ip_proxy=getenv(REMOTE_ADDR);
-                        }
-                        else
-                        {
-                                $ip=getenv(REMOTE_ADDR);
-                        }
-                        return $ip;
-                */
-                        return (isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? $_SERVER['HTTP_X_FORWARDED_FOR'] : $_SERVER['REMOTE_ADDR']);
+                        return (isset($_SERVER['HTTP_X_FORWARDED_FOR']) ? $_SERVER['HTTP_X_FORWARDED_FOR']."," : "").$_SERVER['REMOTE_ADDR'];
                 }