Changeset 7673 for trunk/admin

Timestamp:

12/18/12 16:15:29 (11 years ago)

Author:

douglasz

Message:

Ticket #3236 - Correcoes para Performance: Function Within Loop Declaration.

Location:

trunk/admin/inc

Files:

• class.html_tables.inc.php (modified) (1 diff)
• class.solog.inc.php (modified) (3 diffs)
• class.uiaccounts.inc.php (modified) (3 diffs)
• class.uilog.inc.php (modified) (1 diff)

trunk/admin/inc/class.html_tables.inc.php

@@ -142 +142 @@
                                                 $row = $rows[$rno];
 
-                                                for($pc=0;$pc<count($row);++$pc)
+                        $row_count = count($row);
+                                                for($pc=0;$pc<$row_count;++$pc)
                                                 {
                                                         $c = $row[$cols[$pc]];

trunk/admin/inc/class.solog.inc.php

@@ -40 +40 @@
                                 /* fields from phpgw_log table */
                                 $clist = $this->db->metadata('phpgw_log');
-                                for ($i=0; $i<count($clist); ++$i)
+                $clist_count = count($clist);
+                                for ($i=0; $i<$clist_count; ++$i)
                                 {
                                         $name =  $clist[$i]['name'];
@@ -48 +49 @@
                                 /* fields from phpgw_log_msg table */
                                 $clist = $this->db->metadata('phpgw_log_msg');
-                                for ($i=0; $i<count($clist); ++$i)
+                $clist_count = count($clist);
+                                for ($i=0; $i<$clist_count; ++$i)
                                 {
                                         $name =  $clist[$i]['name'];
@@ -66 +68 @@
                                 /* Enhance with Columns for phpgw_accounts */
                                 $clist = $this->db->metadata('phpgw_accounts');
-                                for ($i=0; $i<count($clist); ++$i)
+                $clist_count = count($clist);
+                                for ($i=0; $i<$clist_count; ++$i)
                                 {
                                         $name =  $clist[$i]['name'];

trunk/admin/inc/class.uiaccounts.inc.php

@@ -816 +816 @@
                         @reset($db_perms);
 
-                        for ($i=0;$i<count($perm_display);++$i)
+            $perm_display_count = count($perm_display);
+                        for ($i=0;$i<$perm_display_count;++$i)
                         {
                                 if ($perm_display[$i]['title'])
@@ -955 +956 @@
                         
                         $tr_color = $GLOBALS['phpgw_info']['theme']['row_off'];
-                        for ($i=0;$i < count($perm_display);++$i)
+            $perm_display_count = count($perm_display);
+                        for ($i=0;$i < $perm_display_count;++$i)
                         {
                                 $app = $perm_display[$i][0];
@@ -1182 +1184 @@
                         {
                                 $groups_select .= '<option value="' . $value['account_id'] . '"';
-                                for ($i=0; $i<count($userGroups); ++$i)
+                $userGroups_count = count($userGroups);
+                                for ($i=0; $i<$userGroups_count; ++$i)
                                 {
                                         /* print "Los1:".$userData["account_id"].$userGroups[$i]['account_id']." : ".$value['account_id']."<br>"; */

trunk/admin/inc/class.uilog.inc.php

@@ -63 +63 @@
                                 {
                                         $c = array();
-                                        for ($i=0;$i<count($_cols);++$i)
+                    $cols_count = count($_cols);
+                                        for ($i=0;$i<$cols_count;++$i)
                                         {
                                                 if (!in_array($i, $_delcol))