Changeset 7673 for trunk/expressoAdmin1_2/inc

Timestamp:

12/18/12 16:15:29 (11 years ago)

Author:

douglasz

Message:

Ticket #3236 - Correcoes para Performance: Function Within Loop Declaration.

Location:

trunk/expressoAdmin1_2/inc

Files:

• class.bomessages_size.inc.php (modified) (2 diffs)
• class.bosectors.inc.php (modified) (2 diffs)
• class.db_functions.inc.php (modified) (2 diffs)
• class.ldap_functions.inc.php (modified) (5 diffs)
• class.socomputers.inc.php (modified) (1 diff)
• class.uimessages_size.inc.php (modified) (1 diff)

trunk/expressoAdmin1_2/inc/class.bomessages_size.inc.php

@@ -285 +285 @@
                         $rules_tr = '';
 
-                        for ($i = 0; $i<count($rules); ++$i)
+            $rules_count = count($rules);
+                        for ($i = 0; $i<$rules_count; ++$i)
                         {
                                 $name_link = (string)str_replace(" ", "%", $rules[$i]['email_recipient']);
@@ -311 +312 @@
                         $rules_tr = '';
 
-                        for ($i = 0; $i<count($rules); ++$i)
+            $rules_count = count($rules);
+                        for ($i = 0; $i<$rules_count; ++$i)
                         {
                                 $name_link = (string)str_replace(" ", "%", $rules[$i]['email_recipient']);

trunk/expressoAdmin1_2/inc/class.bosectors.inc.php

@@ -162 +162 @@
                         $sector_users = $this->so->get_sector_users($sector_dn);
 
-                        for ($i=0; $i<count($sector_users)-1; ++$i)
+            $sector_users_count = count($sector_users)-1;
+                        for ($i=0; $i<$sector_users_count; ++$i)
                         {
                                 //_debug_array($user);
@@ -174 +175 @@
 
                         $sector_groups = $this->so->get_sector_groups($sector_dn);
-                        for ($i=0; $i<count($sector_groups)-1; ++$i)
+            $sector_groups_count = count($sector_groups)-1;
+                        for ($i=0; $i<$sector_groups_count; ++$i)
                         {
                                 $dn = $sector_groups[$i]['dn'];

trunk/expressoAdmin1_2/inc/class.db_functions.inc.php

@@ -141 +141 @@
                 
                 //Escrevre no Banco as aplicações que o gerente tem direito de disponibilizar aos seus usuarios.
-                for ($i=0; $i<count($aplications); ++$i)
+        $aplications_count = count($aplications);
+                for ($i=0; $i<$aplications_count; ++$i)
                 {
                         $sql = "INSERT INTO phpgw_expressoadmin_apps (manager_lid, context, app) "
@@ -415 +416 @@
                 while($this->db->next_record())
                         $user_app[] = $this->db->row();
-                
-                for ($i=0; $i<count($user_app); ++$i)
+
+        $user_app_count = count($user_app);
+                for ($i=0; $i<$user_app_count; ++$i)
                         $return['groups'][] = $user_app[$i]['acl_location'];
                 

trunk/expressoAdmin1_2/inc/class.ldap_functions.inc.php

@@ -1571 +1571 @@
                                 $entry[0]['dn'] = strtolower($entry[0]['dn']);
                                 $sector_dn_array = explode(",", $entry[0]['dn']);
-                                for($i=1; $i<count($sector_dn_array); ++$i)
+                $sector_dn_array_count = count($sector_dn_array);
+                                for($i=1; $i<$sector_dn_array_count; ++$i)
                                         $sector_dn .= $sector_dn_array[$i] . ',';
                                 //Retira ultimo pipe.
@@ -1698 +1699 @@
                                 $entry[0]['dn'] = strtolower($entry[0]['dn']);
                                 $sector_dn_array = explode(",", $entry[0]['dn']);
-                                for($i=1; $i<count($sector_dn_array); ++$i)
+                $sector_dn_array_count = count($sector_dn_array);
+                                for($i=1; $i<$sector_dn_array_count; ++$i)
                                         $sector_dn .= $sector_dn_array[$i] . ',';
                                 //Retira ultimo pipe.
@@ -1831 +1833 @@
                                 $entry[0]['dn'] = strtolower($entry[0]['dn']);
                                 $sector_dn_array = explode(",", $entry[0]['dn']);
-                                for($i=1; $i<count($sector_dn_array); ++$i)
+                $sector_dn_array_count = count($sector_dn_array);
+                                for($i=1; $i<$sector_dn_array_count; ++$i)
                                         $sector_dn .= $sector_dn_array[$i] . ',';
                                 //Retira ultimo pipe.
@@ -1929 +1932 @@
                                 $entry[0]['dn'] = strtolower($entry[0]['dn']);
                                 $sector_dn_array = explode(",", $entry[0]['dn']);
-                                for($i=1; $i<count($sector_dn_array); ++$i)
+                $sector_dn_array_count = count($sector_dn_array);
+                                for($i=1; $i<$sector_dn_array_count; ++$i)
                                         $sector_dn .= $sector_dn_array[$i] . ',';
                                 //Retira ultimo pipe.
@@ -2001 +2005 @@
                                 $entry[0]['dn'] = strtolower($entry[0]['dn']);
                                 $sector_dn_array = explode(",", $entry[0]['dn']);
-                                for($i=1; $i<count($sector_dn_array); ++$i)
+                $sector_dn_array_count = count($sector_dn_array);
+                                for($i=1; $i<$sector_dn_array_count; ++$i)
                                         $sector_dn .= $sector_dn_array[$i] . ',';
                                 //Retira ultimo pipe.

trunk/expressoAdmin1_2/inc/class.socomputers.inc.php

@@ -86 +86 @@
                                         // Recupera o contexto do email_list
                                         $tmp = explode(",", $computer_data['dn']);
-                                        for ($i = 1; $i < count($tmp); ++$i)
+                    $tmp_count = count($tmp);
+                                        for ($i = 1; $i < $tmp_count; ++$i)
                                                 $computer_data['context'] .= $tmp[$i] . ',';
                                         $computer_data['context'] = substr($computer_data['context'],0,(strlen($computer_data['context']) - 1));

trunk/expressoAdmin1_2/inc/class.uimessages_size.inc.php

@@ -114 +114 @@
                         $rules = '';
             $all_rules = $this->bo->get_all_rules();
-                        
-                        for ($i = 0; $i<count($all_rules); ++$i)
+
+            $all_rules_count = count($all_rules);
+                        for ($i = 0; $i<$all_rules_count; ++$i)
                         {       
                                 /* Verificação para não listar a regra default */