Changeset 7673 for trunk/library/mime

Timestamp:

12/18/12 16:15:29 (11 years ago)

Author:

douglasz

Message:

Ticket #3236 - Correcoes para Performance: Function Within Loop Declaration.

Location:

trunk/library/mime

Files:

• mime.php (modified) (8 diffs)
• mimeDecode.php (modified) (5 diffs)
• mimePart.php (modified) (2 diffs)

trunk/library/mime/mime.php

@@ -895 +895 @@
         case !$text && !$html && $attachments:
             $message =& $this->_addMixedPart();
-            for ($i = 0; $i < count($this->_parts); ++$i) {
+            $parts_count = count($this->_parts);
+            for ($i = 0; $i < $parts_count; ++$i) {
                 $this->_addAttachmentPart($message, $this->_parts[$i]);
             }
@@ -903 +904 @@
             $message =& $this->_addMixedPart();
             $this->_addTextPart($message, $this->_txtbody);
-            for ($i = 0; $i < count($this->_parts); ++$i) {
+            $parts_count = count($this->_parts);
+            for ($i = 0; $i < $parts_count; ++$i) {
                 $this->_addAttachmentPart($message, $this->_parts[$i]);
             }
@@ -930 +932 @@
                 $ht =& $this->_addRelatedPart($message);
                 $this->_addHtmlPart($ht);
-                for ($i = 0; $i < count($this->_html_images); ++$i) {
+                $html_images_count = count($this->_html_images);
+                for ($i = 0; $i < $html_images_count; ++$i) {
                     $this->_addHtmlImagePart($ht, $this->_html_images[$i]);
                 }
@@ -939 +942 @@
                 $message =& $this->_addRelatedPart($null);
                 $this->_addHtmlPart($message);
-                for ($i = 0; $i < count($this->_html_images); ++$i) {
+                $html_images_count = count($this->_html_images);
+                for ($i = 0; $i < $html_images_count; ++$i) {
                     $this->_addHtmlImagePart($message, $this->_html_images[$i]);
                 }
@@ -958 +962 @@
                 $this->_addHtmlPart($message);
             }
-            for ($i = 0; $i < count($this->_html_images); ++$i) {
+            $html_images_count = count($this->_html_images);
+            for ($i = 0; $i < $html_images_count; ++$i) {
                 $this->_addHtmlImagePart($message, $this->_html_images[$i]);
             }
@@ -973 +978 @@
                 $this->_addHtmlPart($message);
             }
-            for ($i = 0; $i < count($this->_parts); ++$i) {
+            $parts_count = count($this->_parts);
+            for ($i = 0; $i < $parts_count; ++$i) {
                 $this->_addAttachmentPart($message, $this->_parts[$i]);
             }
@@ -989 +995 @@
             }
             $this->_addHtmlPart($rel);
-            for ($i = 0; $i < count($this->_html_images); ++$i) {
+                    $html_images_count = count($this->_html_images);
+            for ($i = 0; $i < $html_images_count; ++$i) {
                 $this->_addHtmlImagePart($rel, $this->_html_images[$i]);
             }
-            for ($i = 0; $i < count($this->_parts); ++$i) {
+                    $parts_count = count($this->_parts);
+            for ($i = 0; $i < $parts_count; ++$i) {
                 $this->_addAttachmentPart($message, $this->_parts[$i]);
             }
@@ -1008 +1016 @@
                                 $this->_addHtmlPart($message);
             }
-                        
-            for ($i = 0; $i < count($this->_html_images); ++$i) {
+
+                        $html_images_count = count($this->_html_images);
+            for ($i = 0; $i < $html_images_count; ++$i) {
                 $this->_addHtmlImagePart($message, $this->_html_images[$i]);
             }
-            for ($i = 0; $i < count($this->_parts); ++$i) {
+            $parts_count = count($this->_parts);
+            for ($i = 0; $i < $parts_count; ++$i) {
                 $this->_addAttachmentPart($message, $this->_parts[$i]);
             }

trunk/library/mime/mimeDecode.php

@@ -326 +326 @@
 
                     $parts = $this->_boundarySplit($body, $content_type['other']['boundary']);
-                    for ($i = 0; $i < count($parts); ++$i) {
+                    $parts_count = count($parts);
+                    for ($i = 0; $i < $parts_count; ++$i) {
                         list($part_header, $part_body) = $this->_splitBodyHeader($parts[$i]);
                         $part = $this->_decode($part_header, $part_body, $default_ctype);
@@ -386 +387 @@
                 $return[$prepend . $mime_number] = &$structure;
             }
-            for ($i = 0; $i < count($structure->parts); ++$i) {
-
+            $structure_parts_count = count($structure->parts);
+            for ($i = 0; $i < $structure_parts_count; ++$i) {
             
                 if (!empty($structure->headers['content-type']) AND substr(strtolower($structure->headers['content-type']), 0, 8) == 'message/') {
@@ -792 +793 @@
         preg_match_all("/begin ([0-7]{3}) (.+)\r?\n(.+)\r?\nend/Us", $input, $matches);
 
-        for ($j = 0; $j < count($matches[3]); ++$j) {
+        $matches_count = count($matches[3]);
+        for ($j = 0; $j < $matches_count; ++$j) {
 
             $str      = $matches[3][$j];
@@ -943 +945 @@
             // Multiple headers with this name
             if (is_array($headers[$hdr_name])) {
-                for ($i = 0; $i < count($hdr_value); ++$i) {
+                $hdr_value_count = count($hdr_value);
+                for ($i = 0; $i < $hdr_value_count; ++$i) {
                     $output .= Mail_mimeDecode::_getXML_helper($hdr_name, $hdr_value[$i], $indent);
                 }
@@ -954 +957 @@
 
         if (!empty($input->parts)) {
-            for ($i = 0; $i < count($input->parts); ++$i) {
+            $parts_count = count($input->parts);
+            for ($i = 0; $i < $parts_count; ++$i) {
                 $output .= $crlf . str_repeat($htab, $indent) . '<mimepart>' . $crlf .
                            Mail_mimeDecode::_getXML($input->parts[$i], $indent+1) .

trunk/library/mime/mimePart.php

@@ -283 +283 @@
             $encoded['body'] = ''; 
 
-            for ($i = 0; $i < count($this->_subparts); ++$i) {
+            $subparts_count = count($this->_subparts);
+            for ($i = 0; $i < $subparts_count; ++$i) {
                 $encoded['body'] .= '--' . $boundary . $eol;
                 $tmp = $this->_subparts[$i]->encode();
@@ -393 +394 @@
 
         if (count($this->_subparts)) {
-            for ($i = 0; $i < count($this->_subparts); ++$i) {
+            $subparts_count = count($this->_subparts);
+            for ($i = 0; $i < $subparts_count; ++$i) {
                 fwrite($fh, $f_eol . '--' . $boundary . $eol);
                 $res = $this->_subparts[$i]->_encodePartToFile($fh);