Changeset 7673 for trunk/phpgwapi/inc/class.phpmailer.inc.php

Timestamp:

12/18/12 16:15:29 (11 years ago)

Author:

douglasz

Message:

Ticket #3236 - Correcoes para Performance: Function Within Loop Declaration.

File:

• trunk/phpgwapi/inc/class.phpmailer.inc.php (modified) (8 diffs)

trunk/phpgwapi/inc/class.phpmailer.inc.php

@@ -443 +443 @@
     function MailSend($header, $body) {
         $to = "";
-        for($i = 0; $i < count($this->to); ++$i)
+        $to_count = count($this->to);
+        for($i = 0; $i < $to_count; ++$i)
         {
             if($i != 0) { $to .= ", "; }
@@ -497 +498 @@
 
         // Attempt to send attach all recipients
-        for($i = 0; $i < count($this->to); ++$i)
+        $to_count = count($this->to);
+        for($i = 0; $i < $to_count; ++$i)
         {
             if(!$this->smtp->Recipient($this->to[$i][0]))
                 $bad_rcpt[] = $this->to[$i][0];
         }
-        for($i = 0; $i < count($this->cc); ++$i)
+        $cc_count = count($this->cc);
+        for($i = 0; $i < $cc_count; ++$i)
         {
             if(!$this->smtp->Recipient($this->cc[$i][0]))
                 $bad_rcpt[] = $this->cc[$i][0];
         }
-        for($i = 0; $i < count($this->bcc); ++$i)
+        $bcc_count = count($this->bcc);
+        for($i = 0; $i < $bcc_count; ++$i)
         {
             if(!$this->smtp->Recipient($this->bcc[$i][0]))
@@ -515 +519 @@
         if(count($bad_rcpt) > 0) // Create error message
         {
-            for($i = 0; $i < count($bad_rcpt); ++$i)
+            $bad_rcpt_count = count($bad_rcpt);
+            for($i = 0; $i < $bad_rcpt_count; ++$i)
             {
                 if($i != 0) { $error .= ", "; }
@@ -645 +650 @@
         if(count($addr) > 1)
         {
-            for($i = 1; $i < count($addr); ++$i)
+            $addr_count = count($addr);
+            for($i = 1; $i < $addr_count; ++$i)
                 $addr_str .= ", " . $this->AddrFormat($addr[$i]);
         }
@@ -686 +692 @@
         $line = explode($this->LE, $message);
         $message = "";
-        for ($i=0 ;$i < count($line); ++$i)
+        $line_count = count($line);
+        for ($i=0 ;$i < $line_count; ++$i)
         {
           $line_part = explode(" ", $line[$i]);
           $buf = "";
-          for ($e = 0; $e<count($line_part); ++$e)
+          $line_part_count = count($line_part);
+          for ($e = 0; $e<$line_part_count; ++$e)
           {
               $word = $line_part[$e];
@@ -830 +838 @@
 
         // Add custom headers
-        for($index = 0; $index < count($this->CustomHeader); ++$index)
+        $CustomHeader_count = count($this->CustomHeader);
+        for($index = 0; $index < $CustomHeader_count; ++$index)
         {
             $result .= $this->HeaderLine(trim($this->CustomHeader[$index][0]), 
@@ -1053 +1062 @@
 
         // Add all attachments
-        for($i = 0; $i < count($this->attachment); ++$i)
+        $attachment_count = count($this->attachment);
+        for($i = 0; $i < $attachment_count; ++$i)
         {
             // Check for string attachment
@@ -1326 +1336 @@
     function InlineImageExists() {
         $result = false;
-        for($i = 0; $i < count($this->attachment); ++$i)
+        $attachment_count = count($this->attachment);
+        for($i = 0; $i < $attachment_count; ++$i)
         {
             if($this->attachment[$i][6] == "inline")