Changeset 7673 for trunk/prototype

Timestamp:

12/18/12 16:15:29 (11 years ago)

Author:

douglasz

Message:

Ticket #3236 - Correcoes para Performance: Function Within Loop Declaration.

Location:

trunk/prototype

Files:

• modules/catalog/interceptors/CatalogDBMapping.php (modified) (1 diff)
• services/ImapServiceAdapter.php (modified) (3 diffs)
• services/PostgreSQL.php (modified) (1 diff)

trunk/prototype/modules/catalog/interceptors/CatalogDBMapping.php

@@ -23 +23 @@
 
                 if(count($params)>0 && isset($params[0]['id'])){
-                        for($i=0; $i < count($params); ++$i){
+            $params_count = count($params);
+                        for($i=0; $i < $params_count; ++$i){
                                 //Retorna o telefone e o e-mail padrao de um determinado contato
                                 $sql = ' SELECT phpgw_cc_contact_conns.id_typeof_contact_connection as type, phpgw_cc_connections.connection_value as value '

trunk/prototype/services/ImapServiceAdapter.php

@@ -171 +171 @@
                                         if( $filter[0] !== 'msgNumber' )
                                         {
-                                        for( $i = 0; $i < count($filter); ++$i )
-                                        {
-                                                if( count( $filter[$i] ) === 4 )
-                                                $criteria['isExact'] = ( array_shift( $filter[$i] ) === 'AND' );
-
-                                                $criteria[ $filter[$i][0] ] = array( 'criteria' => $filter[$i][2], 'filter' => $filter[$i][1] );
-                                        }
-
-                                        return $this->searchSieveRule($criteria);
+                        $filter_count = count($filter);
+                        for( $i = 0; $i < $filter_count; ++$i )
+                        {
+                            if( count( $filter[$i] ) === 4 )
+                            $criteria['isExact'] = ( array_shift( $filter[$i] ) === 'AND' );
+
+                            $criteria[ $filter[$i][0] ] = array( 'criteria' => $filter[$i][2], 'filter' => $filter[$i][1] );
+                        }
+
+                        return $this->searchSieveRule($criteria);
                                         }
 
@@ -188 +189 @@
 
                                         if( empty( $msgNumber ) )
-                                        return( false );
+                                            return( false );
 
                                         $result = $this->get_info_msgs( array( 'folder' => $folder_name, 
@@ -213 +214 @@
 
                                 $response = array( "page" => $page, "total" => $total_pages, "records" => $count );
-                                
-                                for ($i=0; $i<count($result); ++$i)
+                                $result_count = count($result);
+                                for ($i=0; $i<$result_count; ++$i)
                                 {
                                         $flags_enum = array('Unseen'=> 1,  'Answered'=> 1, 'Forwarded'=> 1, 'Flagged'=> 1, 'Recent'=> 1, 'Draft'=> 1 ); 

trunk/prototype/services/PostgreSQL.php

@@ -358 +358 @@
             $orderDesc = array( $orderDesc );
         }
-
-        for($i=0; $i<count($order); ++$i){
+        $order_count = count($order);
+        for($i=0; $i<$order_count; ++$i){
             $order[$i] .= ($orderDesc[$i] === true) ? ' DESC' : '';
         }