Changeset 7681 for trunk/library/PEAR/PEAR/Installer.php

Timestamp:

12/19/12 16:44:18 (11 years ago)

Author:

douglasz

Message:

Ticket #3236 - Correcoes para Best Practice: Short Open Tag e Best Practice: Always Quote Array Keys.

File:

• trunk/library/PEAR/PEAR/Installer.php (modified) (6 diffs)

trunk/library/PEAR/PEAR/Installer.php

@@ -236 +236 @@
 
             if ((bool) $os->matchSignature($platform) === $negate) {
-                $this->log(3, "skipped $file (meant for $atts[platform], we are ".$os->getSignature().")");
+                $this->log(3, "skipped $file (meant for {$atts['platform']}, we are ".$os->getSignature().")");
                 return PEAR_INSTALLER_SKIPPED;
             }
@@ -264 +264 @@
                 break;
             default:
-                return $this->raiseError("Invalid role `$atts[role]' for file $file");
+                return $this->raiseError("Invalid role '{$atts['role']}' for file $file");
         }
 
@@ -354 +354 @@
                     if ($a['type'] == 'php-const') {
                         if (preg_match('/^[a-z0-9_]+\\z/i', $a['to'])) {
-                            eval("\$to = $a[to];");
+                            eval("\$to = {$a['to']};");
                         } else {
                             if (!isset($options['soft'])) {
-                                $this->log(0, "invalid php-const replacement: $a[to]");
+                                $this->log(0, "invalid php-const replacement: {$a['to']}");
                             }
                             continue;
@@ -374 +374 @@
                         if (is_null($to)) {
                             if (!isset($options['soft'])) {
-                                $this->log(0, "invalid pear-config replacement: $a[to]");
+                                $this->log(0, "invalid pear-config replacement: {$a['to']}");
                             }
                             continue;
@@ -383 +383 @@
                         } else {
                             if (!isset($options['soft'])) {
-                                $this->log(0, "invalid package-info replacement: $a[to]");
+                                $this->log(0, "invalid package-info replacement: {$a['to']}");
                             }
                             continue;
@@ -1586 +1586 @@
                 }
 
-                $this->log(3, "+ cp $ext[file] $copyto");
+                $this->log(3, "+ cp {$ext['file']} $copyto");
                 $this->addFileOperation('rename', array($ext['file'], $copyto));
                 if (!OS_WINDOWS) {