Changeset 7681 for trunk/library/PEAR/PEAR/PackageFile/Generator/v1.php

Timestamp:

12/19/12 16:44:18 (11 years ago)

Author:

douglasz

Message:

Ticket #3236 - Correcoes para Best Practice: Short Open Tag e Best Practice: Always Quote Array Keys.

File:

• trunk/library/PEAR/PEAR/PackageFile/Generator/v1.php (modified) (8 diffs)

trunk/library/PEAR/PEAR/PackageFile/Generator/v1.php

@@ -204 +204 @@
 " <name>$pkginfo[package]</name>";
         if (isset($pkginfo['extends'])) {
-            $ret .= "\n<extends>$pkginfo[extends]</extends>";
+            $ret .= "\n<extends>{$pkginfo['extends']}</extends>";
         }
         $ret .=
@@ -251 +251 @@
         $ret = "$indent <release>\n";
         if (!empty($pkginfo['version'])) {
-            $ret .= "$indent  <version>$pkginfo[version]</version>\n";
+            $ret .= "$indent  <version>{$pkginfo['version']}</version>\n";
         }
         if (!empty($pkginfo['release_date'])) {
-            $ret .= "$indent  <date>$pkginfo[release_date]</date>\n";
+            $ret .= "$indent  <date>{$pkginfo['release_date']}</date>\n";
         }
         if (!empty($pkginfo['release_license'])) {
-            $ret .= "$indent  <license>$pkginfo[release_license]</license>\n";
+            $ret .= "$indent  <license>{$pkginfo['release_license']}</license>\n";
         }
         if (!empty($pkginfo['release_state'])) {
-            $ret .= "$indent  <state>$pkginfo[release_state]</state>\n";
+            $ret .= "$indent  <state>{$pkginfo['release_state']}</state>\n";
         }
         if (!empty($pkginfo['release_notes'])) {
@@ -272 +272 @@
             $ret .= "$indent  <deps>\n";
             foreach ($pkginfo['release_deps'] as $dep) {
-                $ret .= "$indent   <dep type=\"$dep[type]\" rel=\"$dep[rel]\"";
+                $ret .= "$indent   <dep type=\"{$dep['type']}\" rel=\"{$dep['rel']}\"";
                 if (isset($dep['version'])) {
-                    $ret .= " version=\"$dep[version]\"";
+                    $ret .= " version=\"{$dep['version']}\"";
                 }
                 if (isset($dep['optional'])) {
-                    $ret .= " optional=\"$dep[optional]\"";
+                    $ret .= " optional=\"{$dep['optional']}\"";
                 }
                 if (isset($dep['name'])) {
-                    $ret .= ">$dep[name]</dep>\n";
+                    $ret .= ">{$dep['name']}</dep>\n";
                 } else {
                     $ret .= "/>\n";
@@ -302 +302 @@
         if (isset($pkginfo['provides'])) {
             foreach ($pkginfo['provides'] as $key => $what) {
-                $ret .= "$indent  <provides type=\"$what[type]\" ";
-                $ret .= "name=\"$what[name]\" ";
+                $ret .= "$indent  <provides type=\"{$what['type']}\" ";
+                $ret .= "name=\"{$what['name']}\" ";
                 if (isset($what['extends'])) {
-                    $ret .= "extends=\"$what[extends]\" ";
+                    $ret .= "extends=\"{$what['extends']}\" ";
                 }
                 $ret .= "/>\n";
@@ -319 +319 @@
                         $fa['role'] = '';
                     }
-                    $ret .= "$indent   <file role=\"$fa[role]\"";
+                    $ret .= "$indent   <file role=\"{$fa['role']}\"";
                     if (isset($fa['baseinstalldir'])) {
                         $ret .= ' baseinstalldir="' .
@@ -325 +325 @@
                     }
                     if (isset($fa['md5sum'])) {
-                        $ret .= " md5sum=\"$fa[md5sum]\"";
+                        $ret .= " md5sum=\"{$fa['md5sum']}\"";
                     }
                     if (isset($fa['platform'])) {
-                        $ret .= " platform=\"$fa[platform]\"";
+                        $ret .= " platform=\"{$fa['platform']}\"";
                     }
                     if (!empty($fa['install-as'])) {
@@ -427 +427 @@
     function _formatFile($file, $attributes, $indent)
     {
-        $ret = "$indent   <file role=\"$attributes[role]\"";
+        $ret = "$indent   <file role=\"{$attributes['role']}\"";
         if (isset($attributes['baseinstalldir'])) {
             $ret .= ' baseinstalldir="' .
@@ -433 +433 @@
         }
         if (isset($attributes['md5sum'])) {
-            $ret .= " md5sum=\"$attributes[md5sum]\"";
+            $ret .= " md5sum=\"{$attributes['md5sum']}\"";
         }
         if (isset($attributes['platform'])) {
-            $ret .= " platform=\"$attributes[platform]\"";
+            $ret .= " platform=\"{$attributes['platform']}\"";
         }
         if (!empty($attributes['install-as'])) {