Changeset 2249 for sandbox/workflow/branches/609/lib/security/Security.php

Timestamp:

03/15/10 14:41:49 (14 years ago)

Author:

pedroerp

Message:

Ticket #609 - Adaptando os processos do workflow para utilizar o nova factory.

File:

• sandbox/workflow/branches/609/lib/security/Security.php (modified) (5 diffs)

sandbox/workflow/branches/609/lib/security/Security.php

@@ -16 +16 @@
  * executing process code.
  *
- * @package Factory
+ * @package Security
  * @license http://www.gnu.org/copyleft/gpl.html GPL
  * @author Pedro Eugênio Rocha - pedro.eugenio.rocha@gmail.com
@@ -43 +43 @@
          * Returns the current security mode.
          * @access public
-         * @return boolean
+         * @return boolea
+         * @static
          */
         public static function isEnabled() {
@@ -58 +59 @@
         public static function enable() {
 
-                if (self::_isAllowed())
+                if (self::isSafeDir())
                         self::$_protection = true;
                 else
-                        throw new Exception('You are not allowed to change security mode.');
+                        throw new Exception('You are not allowed to change the security mode.');
                 return true;
         }
@@ -73 +74 @@
         public static function disable() {
 
-                if (self::_isAllowed())
+                if (self::isSafeDir())
                         self::$_protection = false;
                 else
-                        throw new Exception('You are not allowed to change security mode.');
+                        throw new Exception('You are not allowed to change the security mode.');
                 return true;
+        }
+
+
+        /**
+         * Implements the security validation.
+         * This function tell us if a fileName is on a safe directory.
+         * For safe dir we mean that no process code exists under it.
+         * The 'depth' parameter specifies the deepness of the file that
+         * we are validate. Default value is to validate the imediate
+         * previous function.
+         *
+         * @access public
+         * @return boolean
+         * @static
+         */
+        public static function isSafeDir($depth = 1) {
+
+                /* our backtrace based policy */
+                $backtrace = debug_backtrace();
+                $originFile = $backtrace[$depth]['file'];
+
+                if (empty($originFile))
+                        return false;
+
+                /* if $fileName is a file under our server root, then it's safe. */
+                if (substr_compare($originFile, EGW_SERVER_ROOT, 0, strlen(EGW_SERVER_ROOT)) == 0)
+                        return true;
+                return false;
         }
 
@@ -93 +122 @@
                 $backtrace = debug_backtrace();
 
-                /* TODO - These are not definitive validations */
+
                 /* $backtrace[1] specifies the imediate antecessor function */
-                $basedir = dirname($backtrace[1]['file']);
+                $originFile = basename($backtrace[1]['file']);
 
-                if ($basedir == dirname(__FILE__))
+
+                /**
+                 * TODO - TODO - TODO - TODO
+                 * We all know that compare file names is a awful thing..
+                 * what makes it even worse is the fact that the file name
+                 * could contain double slashes (e.g. //) caused by wrong
+                 * concatenations. So we cannot compare the whole file path.
+                 * Moreover, if the process has a file named $allowedFile,
+                 * our security will eventually fail..
+                 *
+                 * Anyway, we should think in a better way to validate this...
+                 */
+                if (basename($originFile) == basename($allowedFile))
                         return true;
                 return false;
         }
 }
-
 ?>